jleonard2099 / LHG_CollegeBB

Lance Haffner Courtside College Basketball
GNU Affero General Public License v3.0
5 stars 0 forks source link

First player disabled in rosters when playing #14

Closed jleonard2099 closed 1 year ago

jleonard2099 commented 1 year ago

From Facebook group user Darren Bryan:

One thing I came across playing a computer vs computer game with my teams. I used the 92 season and the first player did not play which was 92 duke laettner and he was not disabled, as well as the opposing teams 1st player

From Facebook group user Rick Young

The first player listed in any roster is disabled if you go review the "Disable Players" prior to starting game, even if you don't select the player. If I don't review "Disable Players" and just start the game, not knowing who system 'disable/bench', then usually first player players game.

Overall, it seems that there is an issue only if you review disabled players first. (which I have never done)

I suspect the issue is primarily caused by a loop / index reference starting at 1 when it should start at 0.

jleonard2099 commented 1 year ago

From my initial runs of the game so far, the last player in each roster appears disabled. Trying several different tests to confirm behavior.

I am seeing an issue with the code logic where converting the keypress to a number (for the index of the players in the array) was off by one. This made A disable B, and ultimately D throw array index errors. This has been corrected and may have been some of the source of this bug as originally reported.

jleonard2099 commented 1 year ago

Looking for people to help test and confirm whether the changes made so far are enough to correct this,

jleonard2099 commented 1 year ago

No issues reported since most recent releases and i was unable to recreate the issue as well.