search

jleonard2099 / LHG_ProBB

Lance Haffner Basketball Pro Game
GNU Affero General Public License v3.0
2 stars 0 forks source link

Several stat values display but are not calculated correctly #15

Closed jleonard2099 closed 1 year ago

jleonard2099 commented 1 year ago

Expanded Leader headers / values don't match selections for individual players. For team totals, the data looks okay but headers don't match.

VIewing Top 10 Leaders doesn't throw errors but isn't correctly calculating number of games, or showing results for teams outside of the first division

jleonard2099 commented 1 year ago

Evaluated looping logic against original and found some mistakes I made with the refactor. Have almost all calculations working now. Expanded Leaders is fine after making sure to pass the correct parameters to these functions, and also making some minor adjustments for menu navigation as well.

jleonard2099 commented 1 year ago

View / Print Top 10's is working but calculates GB (Games Back) based on the first team stored by alphabetic order. The DOS version does this based on Games Won (as expected)

I have looked over the code several times and am wondering if this was a bug fixed in a later version of the game (the latest version I have in DOSBox is newer than what I was given source for)

Looking to adjust now by updating LEAGCMPL to ensure it sorts correctly when writing the .LDR file

jleonard2099 commented 1 year ago

Sorting of games was what the "Complex" subroutine was doing. It didn't have values for AA and ZZ so wasn't sorting. The values showing up accurately were just by chance. Updated the routine to use AA and ZZ values inside of it as they were just constraints for the loop anyway.

All known issues at his point with stat displays and headers should be accurate.