jleonard2099 / LHG_ProBB

Lance Haffner Basketball Pro Game
GNU Affero General Public License v3.0
2 stars 0 forks source link

Recorded stats seem really high #22

Closed jleonard2099 closed 6 months ago

jleonard2099 commented 9 months ago

After updating the league leaders to follow NBA minimum requirements for posting, I noticed when viewing the results from an NBA season that values were larger than the alloted width of the output.

For example, blocks were reporting in the thousands for some team totals, when only 3 spaces were available.

Similar behavior with points, where 4 spaces are alloted but 5 are needed to display.

I can update the display to include the extra digit, so that things don't push to a new line. But this made me consider the accuracy of the numbers. The record # of blocks by a team is 716, so it should be near impossible for there to be over 1,000.

This tells me there are a few causes: 1) the game generates too many stats (ie, was not designed to handle newer teams well?) 2) the game records too many stats 3) the code isn't properly initializing / totalling stats when compiling

We need to determine which it is. A good place to start from is generating a season in both the DOS version and mine, for the same year, and seeing what values / averages we get.

jleonard2099 commented 9 months ago

I didn't jot down which season this was for, but in general I have now come to realize that the game very often generates much higher stats than is normal for a Basketball season. The pacing of the game is very inaccurate outside of certain years / decades (closer to when the game was developped)

It is anticipated that getting the pacing of the game / accuracy of the FTA/FGA/Rebounds more in line with real life will take care of this.

After the most recent rounds of testing are complete, I will revisit this to confirm. The game shouldn't be designed to handle values of stats that would never happen in real life.

jleonard2099 commented 8 months ago

The last tests done in this did confirm my theories so far; several seasons across several decades were generated with an adjusted "pacing" and I have not run into this issue.

It was also considered if a cumulative was being output because of initialization problems.

From my memory the latter of these was the primary issue.

This will likely be closed after taking a final chance to review stats from several teams with the replays performed.

jleonard2099 commented 6 months ago

Closing issue