search

jlepage / CFQRCode

Coldfusion CFML QR-Code Generator - Write QRCode to a file with less effort
7 stars 7 forks source link

QRCode.cfc setColor setBackground decimal transparency inconsistent with _getARGBColor hexadecimal alpha #4

Open Conrad-T-Pino opened 2 years ago

Conrad-T-Pino commented 2 years ago

setColor setBackground transparency argument default (255) and hint text both imply numeric decimal type while the _getARGBColor alpha argument is clearly a hexadecimal string.

The "index.cfm" template invokes setColor with single string argument; ignoring setBackground method altogether.

IMO setColor setBackground hexColor can be safely retyped from any to string. Is setColor setBackground transparency retyping from any to numeric reasonable? What other considerations for backwards compatibility are worth while considering?