search

jlepird / next-gen-assignments

Source code for
https://af-talent-marketplace.app.cloud.gov
Other
2 stars 0 forks source link

Overseas #3

Closed johangithub closed 7 years ago

johangithub commented 7 years ago

Hi, I'm new here. I am just learning the codebase and I see that Alabama is flagged as Overseas. Is this on purpose? Maybe you meant to say AK?

https://github.com/jlepird/next-gen-assignments/blob/f0162b703d88cc720770f132e4e011f5d3cd0dd0/billets/find.php#L450-L457

        var conus = billets.dimension(function(x){
            if ("state" in x){
               return x.state == "OCONUS" || x.state == "HI" || x.state == "AL" ? "OCONUS" : "CONUS";  
            } else {
                return "(Unknown)";
            }

        });
        var conusGroup = conus.group();
jlepird commented 7 years ago

Although Alabama may feel like a different country, I guess it should be included as part of CONUS.