jlesage / docker-baseimage-gui

A minimal docker baseimage to ease creation of X graphical application containers
MIT License
1.2k stars 179 forks source link

install_app_icon.sh does not support local image resources #95

Closed jerry-yuan closed 1 year ago

jerry-yuan commented 1 year ago

I am transplanting a .deb packaged application whitch will intall a .application file and icons to /usr/share. I'd like to use the images in deb package as icon. But either file url or dataurl could be the $APP_ICON_URL's value.

I have checked the script, the file url will be failed when generating favicons using realfavicongenerator: image while dataurl will be failed when downloading master icon for the reason that curl does not support dataurl: image

How could I use the local resources as the icon?

jlesage commented 1 year ago

Currently the helper does not support local file icon. It must be an URL pointing to the icon.

I can check to add support for local files. In the meantime, you can:

jerry-yuan commented 1 year ago

Currently the helper does not support local file icon. It must be an URL pointing to the icon.

I can check to add support for local files. In the meantime, you can:

  • Find the same icon on the Internet.
  • Add the icon to your repository (e.g. Github) and use the URL from there.
  • Manually generate the icons from https://realfavicongenerator.net and add the results to the container image.

Thanks, I have used the first way and find a low resolution icon from official website😂

But I'm curious about the third way, is there any docs about how can I provide icon resources directly?

jlesage commented 1 year ago

But I'm curious about the third way, is there any docs about how can I provide icon resources directly?

No documentation on this, since you basically do yourself what the helper is doing: you generate from the site the icons and download the package. Then you extract the package and copy the requires files in your source tree, under your rootfs directory.

But I worked on that and the helper in the next version of the image will support path to a local file :)

jerry-yuan commented 1 year ago

But I'm curious about the third way, is there any docs about how can I provide icon resources directly?

No documentation on this, since you basically do yourself what the helper is doing: you generate from the site the icons and download the package. Then you extract the package and copy the requires files in your source tree, under your rootfs directory.

But I worked on that and the helper in the next version of the image will support path to a local file :)

Thanks for your reply, I'm looking forward to the next new version.