search

jlesage / docker-firefox

Docker container for Firefox
MIT License
1.61k stars 288 forks source link

Docker crashes if I close Firefox within the session #149

Open alirz1 opened 1 year ago

alirz1 commented 1 year ago

Running this in docker on a synology NAS. If I close Firefox, the entire docker for this crashes.

jlesage commented 1 year ago

The container crashes or stops ? Note that by default, terminating Firefox also terminates the container. You can change this behaviour by setting the KEEP_APP_RUNNING environment variable. See https://github.com/jlesage/docker-firefox#environment-variables.

gofunn commented 1 year ago

@jlesage I think the better way to prevent it is set a firefox variable not the [supervisor].

-e "FF_PREF_HTTP_PROXY=browser.tabs.closeWindowWithLastTab=false"

hope to add it to dockerfile

jlesage commented 1 year ago

Thanks for the suggestion @gofunn. While this won't prevent the container from shutting down if Firefox is closed (when KEEP_APP_RUNNING=0), it seems to be a good default setting to have to prevent Firefox from closing when the last tab is closed. This will be part of the next version :)