jlesage / docker-handbrake

Docker container for HandBrake
MIT License
864 stars 98 forks source link

[Bug] Unable to disable watch and output folders from mounting #328

Open shanelord01 opened 9 months ago

shanelord01 commented 9 months ago

Current Behavior

I have these disabled in my docker-compose:

-v /home/user/HandBrake/watch:/watch:rw \

-v /home/user/HandBrake/output:/output:rw \

and put AUTOMATED_CONVERSION=0 in my environment

but these directories are still being mounted as non persistent volumes

Expected Behavior

Don't create mounts for them if automated conversion is disabled and they are not required

Steps To Reproduce

comment out the volumes and set AUTOMATED_CONVERSION=0

You will see docker create non persistent volumes for these.

Environment

Container creation

version: '3' services: handbrake: image: jlesage/handbrake:latest ports:

volumes: handbrake_config: external: true video_nfs: external: true

Container log

n/a

Container inspect

No response

Anything else?

No response

jlesage commented 9 months ago

This is a behaviour of Docker: these volumes are created because /watch and /output folders are declared in the Dockerfile. If a mapping is not explicitly set, Docker will use a temporary volume.

shanelord01 commented 9 months ago

Thanks. Is there Any way to make them optional and become disabled if the AUTOMATED_CONVERSION=0 is set?

jlesage commented 9 months ago

Not to my knowledge. Volumes creation is not controlled by the container itself.