search

jlesage / docker-makemkv

Docker container for MakeMKV
MIT License
440 stars 50 forks source link

Java version for maintitle detection not working #102

Closed mattk926 closed 3 years ago

mattk926 commented 3 years ago

I have tried using latest java for mainttitle detection and it doesnt appear to be functional. version 8 is the version that I believe makemkv required for mainttitle detection to function correctly.

mattk926 commented 3 years ago

Just a follow-up comment. I forked and changed the container to use jsut openjdk8-jre and it seems to have solved the problem. I will leave it up to jlesage to determine how to incorporate these findings.

jlesage commented 3 years ago

Thanks for the follow-up. The container is not using version 8 because it causes MakeMKV to crash with certain types of protection. I never found a version that works in all cases.

Since MakeMKV has been updated a couple of times since the last time I tried this, I will see if I can reproduce the crash with the latest version.

jlesage commented 3 years ago

Looks like the crash has been fixed :) I will revert to Java 8.

mattk926 commented 3 years ago

Release 1.16.0 fixed this issue Thank you!