search

jlesage / docker-makemkv

Docker container for MakeMKV
MIT License
427 stars 50 forks source link

MakeMKV crashes with FFmpeg 3.4.2 #20

Closed C4Wiz closed 3 years ago

C4Wiz commented 6 years ago

when trying to convert TrueHD tracks to DD 5.1 i get a fatal error. nothing in the logs.

this did not happen on the past builds

maybe we should revert to the 2.8 branch

jlesage commented 6 years ago

I removed the v1.9.0 docker image and remapped the latest tag to v1.8.0.

jlesage commented 6 years ago

I can produce a beta image with ffmpeg 4.0. Are you willing to test it?

C4Wiz commented 6 years ago

i would be willing to test it

C4Wiz commented 6 years ago

what is the dir location in the docker for the makemkv default conversion profiles?

jlesage commented 6 years ago

The image is currently building (https://hub.docker.com/r/jlesage/makemkv/builds/). To use it, you will need to use the docker tag v1.9.0-beta1.

jlesage commented 6 years ago

The default conversion profiles are defined internally in MakeMKV. If you want to create your own profile, you can start from an existing example. Example profiles are in the data directory of your appdata. For example, if your appdata is /mnt/user/appdata/MakeMKV, you can do:

cp /mnt/user/appdata/MakeMKV/flac.mmcp.xml.example /mnt/user/appdata/MakeMKV/my_flac.mmcp.xml

Then edit the new profile and restart the container.

C4Wiz commented 6 years ago

right i get that, i am asking where the default profiles are stored in the container so i can remove them, as i have already created my own

jlesage commented 6 years ago

Ok your own profiles are under the data directory that you can find either under the host's appdata or container's /config folder.

C4Wiz commented 6 years ago

correct

but where are the default profiles installed by MakeMKV?

C4Wiz commented 6 years ago

the beta build still crashes makemkv when converting truehd to ac3

jlesage commented 6 years ago

The default profiles (AAC-stereo, FLAC, WDTV) are not mapped to any file. They are internal to MakeMKV. To my knowledge they can be removed or modified.

jlesage commented 6 years ago

Which profile are you using to reproduce the crash?

C4Wiz commented 6 years ago

in windows and mac versions they are installed to the data directory

C4Wiz commented 6 years ago

here is my profile to create a AC3 track from a TrueHD track:

TrueHD+DD.mmcp.xml.zip

C4Wiz commented 6 years ago

i just noticed the built in profiles are no longer installed to the user config dir, they are now dynamic in a tar file called appdata.tar, if i rename the tar file. they are removed from the list. but MakeMKV complains on startup

C4Wiz commented 6 years ago

any progress on this?

jlesage commented 6 years ago

No not yet. I would like first to see if the problem can be reproduced on a “normal” system. If this is the case, it’s then probably an issue with MakeMKV that I can’t fix.

jlesage commented 6 years ago

https://www.makemkv.com/forum2/viewtopic.php?f=3&t=17550

C4Wiz commented 6 years ago

yea i posted that

jlesage commented 3 years ago

@C4Wiz , is this still an issue ?

C4Wiz commented 3 years ago

@C4Wiz , is this still an issue ?

Just tested, no it is not

jlesage commented 3 years ago

Ok, thanks!