[Bug] Folder bind mounts in docker contianer not working

jlesage / docker-makemkv

Docker container for MakeMKV

MIT License

435 stars 50 forks source link

[Bug] Folder bind mounts in docker contianer not working #204

Closed x0tester0x closed 6 months ago

x0tester0x commented 7 months ago

Current Behavior

The /storage and the /output folders used in docker compose are bind mounts, but they are not working inside the docker contianer.

Expected Behavior

No response

Steps To Reproduce

No response

Environment

OS: DietPi
OS version: 9.0.0
CPU: ARM
Docker version: latest
Device model: Compute Module 4
Browser/OS: Microsoft Edge

Container creation

makemkv: image: jlesage/makemkv:latest container_name: makemkv hostname: makemkv restart: always user: 0:0 environment:

PUID=0
PGID=0
TZ=Europe/Rome
DARK_MODE=true volumes:
./makemkv/config:/config
./makemkv/input:/storage
./makemkv/output:/output

Container log

No Error visible in the log....

Container inspect

No response

Anything else?

No response

TomTinking commented 6 months ago

Are you sure your PUID and PGID are correct. Looks like you are using 0 -> root. https://superuser.com/questions/626843/does-the-root-account-always-have-uid-gid-0 From what I have learnt so far in Docker is running a container as 0/0 i.e. root is dangerous as you give that container root access to the host without question. I am no docker expert, but generally the ID for my home setups maps to a user (usually my main one that I run most apps with) This is more often than not 1000 and 1000

This is not a bug as its not replicated by anyone else.. check your config

x0tester0x commented 6 months ago

OK, I did change the PUID and GUID to 1000, but then I get an error.

/startapp.sh: cd: line 16: can't cd to /storage: Permission denied

The /storage folder is a bind mount to /mnt/storage and there also the permissions are correct...

jlesage commented 6 months ago

Not sure where they are coming from, but PUID/PGID variables are not used by the container. You need to use USER_ID and GROUP_ID. You have to make sure the configured user can access /makemkv/input and other mapped folder. See https://github.com/jlesage/docker-makemkv?tab=readme-ov-file#usergroup-ids

TomTinking commented 6 months ago

Good point. was just looking at what they had used to create. now looking at my setup is using USER_ID .. But I assume they still need to map to valid OS user ids that have access to mount Also not sure why they dint just build using your compose or instructions ?

x0tester0x commented 6 months ago

Not sure where they are coming from, but PUID/PGID variables are not used by the container. You need to use USER_ID and GROUP_ID. You have to make sure the configured user can access /makemkv/input and other mapped folder. See https://github.com/jlesage/docker-makemkv?tab=readme-ov-file#usergroup-ids

This was it. Thanks