search

jlesage / docker-makemkv

Docker container for MakeMKV
MIT License
435 stars 50 forks source link

Disc not auto ejecting after rip is finished #84

Open ghost opened 4 years ago

ghost commented 4 years ago

Amazing app, works like a charm, and stores the disk on my server. However when the rip is finished it does not eject. I am running ubuntu server 18.04 lts

the code I used

sudo docker run -d --restart unless-stopped \ --name=makemkv \ -p 5800:5800 \ -v /docker/appdata/makemkv:/config:rw \ -v $HOME:/storage:ro \ -v $HOME/mnt/media/:/output:rw \ -e AUTO_DISC_RIPPER=1 \ -e AUTO_DISC_RIPPER_EJECT=1 \ -e AUTO_DISC_RIPPER_PARALLEL_RIP=1 \ -e AUTO_DISC_RIPPER_MIN_TITLE_LENGTH=1200 \ --device /dev/sg0 \ --device /dev/sg1 \ jlesage/makemkv

I tried to change -e AUTO_DISC_RIPPER_EJECT=1 \ to 0 but that had no effect. I am new to linux and docker so I am unsure how to generate a log

Update Jlesage is amazing :) It was fixed with their suggestion

sudo docker run -d --restart unless-stopped \ --name=makemkv \ -p 5800:5800 \ -v /docker/appdata/makemkv:/config:rw \ -v $HOME:/storage:ro \ -v $HOME/mnt/media/:/output:rw \ -e AUTO_DISC_RIPPER=1 \ -e AUTO_DISC_RIPPER_PARALLEL_RIP=1 \ -e AUTO_DISC_RIPPER_MIN_TITLE_LENGTH=1200 \ -e AUTO_DISC_RIPPER_EJECT=1 \ --device /dev/sg0 \ --device /dev/sg1 \ --device /dev/sr0 \ --device /dev/sr1 \ jlesage/makemkv

ghost commented 4 years ago

I've tried tinkering with it all weekend still no luck, if anyone has any ideas

jlesage commented 4 years ago

Can you provide the container's log (docker logs makemkv)?

ghost commented 4 years ago

When I do a sudo docker exec makemkv lsscsi -g -k

[4:0:0:0] cd/dvd HL-DT-ST BD-RE WH16NS60 1.02 /dev/sr0 /dev/sg0 [5:0:0:0] cd/dvd HL-DT-ST BD-RE WH16NS60 1.00 /dev/sr1 /dev/sg1 [N:0:1:1] disk ADATA SX6000LNP__1 /dev/nvme0n1

jlesage commented 4 years ago

First messages are missing from the logs you provided. You may need to restart the container and take them again.

I think you may need to expose additional devices to the container. This should be indicated in the container's log.

jlesage commented 4 years ago

Thanks, try to also expose /dev/sr0 and /dev/sr1 (so you should have 4 devices exposed).

filbot commented 3 years ago

I have the same issue but I think a different situation. I'm running this docker container on a Synology NAS with an externally (USB) attached dvd drive. The host controller for this drive is showing as a dash.

root@nas:~# docker exec makemkv lsscsi -g -k [0:0:0:0] disk WDC WD120EDAZ-11F3RA0 0A81 /dev/sata1 /dev/sg0 [1:0:0:0] disk WDC WD120EDAZ-11F3RA0 0A81 /dev/sata2 /dev/sg1 [4:0:0:0] disk Synology DiskStation DL17 /dev/synoboot /dev/sg2 [22:0:0:0] cd/dvd HL-DT-ST BD-RE WH14NS40 1.03 - /dev/sg4

And the docker logs show this:

[cont-init.d] 95-check-optical-drive.sh: found optical drive [-, /dev/sg4], group 0. [cont-init.d] 95-check-optical-drive.sh: WARNING: for best performance, the host device - needs to be exposed to the...

Is this just a limitation of the controller used for the external dvd drive or is there something I can do? Backup works fine if I just specify /dev/sg4 but will not eject when completed.

torrencj commented 2 years ago

I have the same issue but I think a different situation. I'm running this docker container on a Synology NAS with an externally (USB) attached dvd drive. The host controller for this drive is showing as a dash.

root@nas:~# docker exec makemkv lsscsi -g -k [0:0:0:0] disk WDC WD120EDAZ-11F3RA0 0A81 /dev/sata1 /dev/sg0 [1:0:0:0] disk WDC WD120EDAZ-11F3RA0 0A81 /dev/sata2 /dev/sg1 [4:0:0:0] disk Synology DiskStation DL17 /dev/synoboot /dev/sg2 [22:0:0:0] cd/dvd HL-DT-ST BD-RE WH14NS40 1.03 - /dev/sg4

And the docker logs show this:

[cont-init.d] 95-check-optical-drive.sh: found optical drive [-, /dev/sg4], group 0. [cont-init.d] 95-check-optical-drive.sh: WARNING: for best performance, the host device - needs to be exposed to the...

Is this just a limitation of the controller used for the external dvd drive or is there something I can do? Backup works fine if I just specify /dev/sg4 but will not eject when completed.

Ever sort this out? Seems to me that synology doesn't have the right kernel support that the app expects. I've managed to get auto ripping but not auto ejecting to work.

alexindigo commented 1 year ago

Same here, Synology, even in command line it doesn't work:

$ eject
eject: /dev/cdrom: not found mountpoint or device with the given name
$ eject /dev/sg6
eject: /dev/sg6: not found mountpoint or device with the given name

But ripping goes through totally fine

jlesage commented 1 year ago

Can you try with the latest image to see if it's better ?

Kelto66 commented 9 months ago

Same here, Synology, even in command line it doesn't work:

$ eject
eject: /dev/cdrom: not found mountpoint or device with the given name
$ eject /dev/sg6
eject: /dev/sg6: not found mountpoint or device with the given name

But ripping goes through totally fine

I am having the same issue with a QNAP NAS. I am running the latest image and it's still having the issue.

jlesage commented 9 months ago

Can you share the container's log ?

Kelto66 commented 9 months ago

Can you share the container's log ?

[autodiscripper] [makemkvcon] Copy complete. 7 titles saved. [autodiscripper] Disc rip terminated successfully. [autodiscripper] Ejecting disc from drive 0 (/dev/sg4)... [autodiscripper] ERROR: Failed to eject drive 0 (/dev/sg4): eject: /dev/sg4: not found mountpoint or device with the given name.