search

jlesage / docker-nginx-proxy-manager

Docker container for Nginx Proxy Manager
MIT License
770 stars 173 forks source link

Diffie Hellmann Params dhparam #282

Open HomemadeAdvanced opened 1 year ago

HomemadeAdvanced commented 1 year ago

Hi, is it possible to add the possibility to add the Diffie Hellmann parameters to add an extra layer of security?

Mattie112 commented 1 year ago

You can add a config with exactly what you want, see https://github.com/NginxProxyManager/nginx-proxy-manager/issues/564 for an example

HomemadeAdvanced commented 1 year ago

@Mattie112 Allright that seems to be a good solution but it would be great if the option to use dhparam in the GUI was implemented.

Mattie112 commented 1 year ago

As far as I know you can only set the ciphers per server, not per (v)host. Server settings are not implemented in the UI. (but I am running an older version so don't quote me on that)

HomemadeAdvanced commented 1 year ago

So maybe it is possible to change the image so that a parameter in a docker compose file could be added to add dhparam. Opened an issue in the main repo a while ago: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/2539 But I don't have big hopes that it is implemented any time soon. I have set up NPM to make it easier to set up my reverse proxy but your solution seems to be working but I would like to have something to deploy and forget (I know not always possible). Maybe I take a look at some other projects like traeffik or so. Thanks a lot.