search

jlesage / docker-nginx-proxy-manager

Docker container for Nginx Proxy Manager
MIT License
756 stars 166 forks source link

update to npm 2.10.2 #290

Closed ndaringer closed 7 months ago

ndaringer commented 1 year ago

I use the docker, any chance this could be updated?

https://www.reddit.com/r/selfhosted/comments/12de7bw/nginx_proxy_manager/ caught my attention.

whoshoe commented 1 year ago

Yes, please update it to at least 2.19.22 to mitigate those security issues.

zhdenny commented 1 year ago

Anyone know what needs to change to migrate from https://hub.docker.com/r/jlesage/nginx-proxy-manager to https://hub.docker.com/r/jc21/nginx-proxy-manager

https://hub.docker.com/r/jc21/nginx-proxy-manager is at least able to be on latest version that fixes the security issues.

Seems there are pretty big port and path changes that are required to migrate but might be MORE. I don't know.

serverless83 commented 1 year ago

Yes, please update it to at least 2.19.22 to mitigate those security issues.

The image has been updated to 2.9.22 version 2 days ago, thank you @jlesage

ndaringer commented 1 year ago

@serverless83 It is not updated. This is a fresh pull. If it had been updated, it would be 2.10.2. image

serverless83 commented 1 year ago

@serverless83 It is not updated. This is a fresh pull. If it had been updated, it would be 2.10.2. image

Infact, as I said, the version is 2.9.22 that is not affected by the vulnerability.

zhdenny commented 1 year ago

I'm confused.....v2.19.22 or v2.9.22. screenshot and what you say show two different things. Are you sure???? Just looking at your message from last week.

v2.9.22+ is the version not affected by the vulnerability.

serverless83 commented 1 year ago

Original message corrected with the right version number, btw the latest version is 2.10.2

ndaringer commented 1 year ago

There is no v 2.19.22.

On Sun, Apr 16, 2023, 4:10 PM zhdenny @.***> wrote:

I'm confused.....v2.19.22 or v2.9.22. screenshot and what you say show two different things. Are you sure????

v2.19.22 is the version not affected by the vulnerability.

— Reply to this email directly, view it on GitHub https://github.com/jlesage/docker-nginx-proxy-manager/issues/290#issuecomment-1510475427, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABSVHXEKODT2QK5DMRSCO3XBRG4VANCNFSM6AAAAAAWV2C5JY . You are receiving this because you authored the thread.Message ID: @.***>

voodoopt commented 12 months ago

Anyone know what needs to change to migrate from https://hub.docker.com/r/jlesage/nginx-proxy-manager to https://hub.docker.com/r/jc21/nginx-proxy-manager https://hub.docker.com/r/jc21/nginx-proxy-manager is at least able to be on latest version that fixes the security issues. Seems there are pretty big port and path changes that are required to migrate but might be MORE. I don't know. This is my changes

on image: jlesage/nginx-proxy-manager my settings are ports:

on image: jc21/nginx-proxy-manager are ports:

zhdenny commented 12 months ago

Anyone know what needs to change to migrate from https://hub.docker.com/r/jlesage/nginx-proxy-manager to https://hub.docker.com/r/jc21/nginx-proxy-manager https://hub.docker.com/r/jc21/nginx-proxy-manager is at least able to be on latest version that fixes the security issues. Seems there are pretty big port and path changes that are required to migrate but might be MORE. I don't know. This is my changes

on image: jlesage/nginx-proxy-manager my settings are ports: - 81:8181 environment: - DB_SQLITE_FILE=database.sqlite

on image: jc21/nginx-proxy-manager are ports: - 81:81 environment: - DB_SQLITE_FILE=/data/database.sqlite volumes: - ./data:/data # add this volume

Have you tested this migration yourself?

voodoopt commented 12 months ago

Anyone know what needs to change to migrate from https://hub.docker.com/r/jlesage/nginx-proxy-manager to https://hub.docker.com/r/jc21/nginx-proxy-manager https://hub.docker.com/r/jc21/nginx-proxy-manager is at least able to be on latest version that fixes the security issues. Seems there are pretty big port and path changes that are required to migrate but might be MORE. I don't know. This is my changes

on image: jlesage/nginx-proxy-manager my settings are ports: - 81:8181 environment: - DB_SQLITE_FILE=database.sqlite on image: jc21/nginx-proxy-manager are ports: - 81:81 environment: - DB_SQLITE_FILE=/data/database.sqlite volumes: - ./data:/data # add this volume

Have you tested this migration yourself?

yes ;)

jlesage commented 7 months ago

Closing this issue, version 2.10.4 integrated a while ago.