Better gitlibs support - Githubissues

jlesquembre / clj-nix

Nix helpers for Clojure projects

https://jlesquembre.github.io/clj-nix/

Eclipse Public License 2.0

138 stars 19 forks source link

Better gitlibs support #120

Closed mjmeintjes closed 2 months ago

mjmeintjes commented 3 months ago

This adds support for dependencies that specify :git/tag and shortened :git/sha

Also fixes #108 "Manifest not found error" for dependencies using :deps/root

Changes:

Pre-calculate information about rev ancestors and store in lock file
Bump lock file version
Store git repo info in nix store under ${git-dir}/revs/REV
Add fake git command to provide git tags and rev ancestor information at build time using the git repo info stored in ${git-dir}/revs/REV (fixes #61)

mjmeintjes commented 3 months ago

Can you have a look at the tests in fake_git_test.clj to see why they are failing? They pass when I run them locally, and I don't know enough about Github Actions to figure out why they are failing.

❯ kaocha
       unit:   100% [==================================================] 13/13
integration:   100% [==================================================] 15/15
28 tests, 61 assertions, 0 failures.

I could also just comment out the tests.

jlesquembre commented 3 months ago

@mjmeintjes thanks, let's keep the tests, I'll try to find why are failing only on CI

mjmeintjes commented 2 months ago

It seems that the extra-pkgs/babashka/deps-lock.json needs to be regenerated to work with the new lock file version. How do I do this?

jlesquembre commented 2 months ago

@mjmeintjes thanks, on my local babashka clone I run

nix run ~/projects/clj-nix#deps-lock -- --lein --deps-exclude resources/META-INF/babashka/deps.edn

I'm going to update it

jlesquembre commented 2 months ago

I updated the lock files, and updated calc-ancestors to return a sorted-map, I'm waiting for CI to finish before merging it.

@mjmeintjes I apologize for the delay in addressing this PR, but thanks again for your work!