search

jlesquembre / clj-nix

Nix helpers for Clojure projects
https://jlesquembre.github.io/clj-nix/
Eclipse Public License 2.0
139 stars 20 forks source link

breaking: remove hidden/dotfiles from deps-lock by default #33

Closed thenonameguy closed 1 year ago

thenonameguy commented 1 year ago

I'm using direnv in my projects + a top-level deps-lock.json The cache folder of direnv puts paths into the file-seq:

.direnv/flake-inputs/9zrqx8iyyh1ss30qnz65620sb293301n-source/backend/deps.edn

These should be IMO removed by default and are hard to remove with the current deps-ignore since the path string overlaps with my wanted deps.edn paths.

This is a breaking change, but IMO it should be not a huge concern for most normal use-cases.

Changing the implementation to use fs/glob automatically does this filtering.

jlesquembre commented 1 year ago

Thanks and sorry for taking that long to answer, I want to test it a bit before merging it, but it makes sense to ignore hidden files by default.

Related to this, I want to refactor the desp-lock generator CLI, to make easier to define the files to include/skip, but after addressing this PR.

jlesquembre commented 1 year ago

Merged (with git CLI), thank you.

Not sure why github didn't close the PR automatically, but you can see your commits in main :)