jlesquembre / clj-nix

Nix helpers for Clojure projects
https://jlesquembre.github.io/clj-nix/
Eclipse Public License 2.0
139 stars 20 forks source link

add java opts option #36

Closed ekimber closed 1 year ago

jlesquembre commented 1 year ago

Thanks, while I want to add support for java options, I'm not sure if that's the right approach. I want to avoid recompile the derivation just because the java options changed.

Maybe a better approach could be to create a wrapper with JDK_JAVA_OPTIONS: https://docs.oracle.com/en/java/javase/11/tools/java.html

ekimber commented 1 year ago

Yes I can understand that you would prefer to do it that way, it is a runtime rather than compile time thing. Though in my use case the options are essential and won't change

jlesquembre commented 1 year ago

I'm reopening it to not forget about it

jlesquembre commented 1 year ago

@ekimber sorry for taking that long to address this. I'm merging it, it's nice to have that option available, we can optimize it in another PR