jlesquembre / clj-nix

Nix helpers for Clojure projects
https://jlesquembre.github.io/clj-nix/
Eclipse Public License 2.0
139 stars 20 forks source link

Upstream mkBabashka? #72

Open sg-qwt opened 1 year ago

sg-qwt commented 1 year ago

Hi Jose,

Thanks for the great work. Babashka has only a fixed number of feature flags.

Wondering if it's possible to upstream the work of mkBabashka to nixpkgs, so that consume babashka.override { withExtraFeatures = [ "jdbc"] } from nixpkgs would be easy without this flake?

Best

jlesquembre commented 1 year ago

I'd like to upstream clj-nix, or parts of it, to nixpkgs. I like the poetry2nix approach: https://github.com/NixOS/nixpkgs/tree/b373c3322762d14e5aa0cedd18877047e3c3f7f4/pkgs/development/tools/poetry2nix/poetry2nix

mkBabashka depends on functionality provided by clj-nix, like the locker file generator or the helpers to generate uberjars. We need to upstream those too, but unfortunately, I think clj-nix needs to be more mature before it can be upstreamed to nixpkgs.

LiGoldragon commented 2 months ago

A big advantage of flakes is to open more possibilies than adding to an enormous monorepo. Merging into nixpkgs now is only for visibility, which now deserves its own project.