Closed Sohalt closed 1 year ago
Good catch. I think in that case makes more sense to simple ignore those dependencies.
patch-git-sha
should expand only the sha
s in the lock file, ignoring the others (instead of failing). Makes sense? I don't think we need to save the included/excluded files in the lock file.
We should be able to deal with files called deps.edn
that are not valid edn.
What's the use case to deal with deps.edn files that aren't valid edn?
On Wed, Aug 9, 2023, 09:12 Sohalt @.***> wrote:
We should be able to deal with files called deps.edn that are not valid edn.
— Reply to this email directly, view it on GitHub https://github.com/jlesquembre/clj-nix/issues/78#issuecomment-1670794243, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAICNSAY5IACCGJYEW5GAULXUMZ7FANCNFSM6AAAAAA3G3ER5A . You are receiving this because you were assigned.Message ID: @.***>
I have a deps.edn
with {{}}
placeholders for use with deps-new templating.
@Sohalt could you try #80?
@Sohalt I merged #80, but feel free to reopen if something doesn't work as expected.
Thank you! And sorry for not getting back on this earlier. I just tried it and it works as expected!
@Sohalt no worries, thanks for testing it!
While it's already possible to include/exclude some
deps.edn
files in lockfile generation (using--deps-include
and--deps-exclude
), thepatch-git-sha
command duringpatchPhase
tries to patch alldeps.edn
files. It would be nice to be able to granularly specify which files to patch (or record which files where included/excluded in the lockfile and have the patch phase automatically pick that up).