search

jlesquembre / clj-nix

Nix helpers for Clojure projects
https://jlesquembre.github.io/clj-nix/
Eclipse Public License 2.0
138 stars 19 forks source link

BUG: customJdk ignores java-opts #92

Closed uvNikita closed 11 months ago

uvNikita commented 11 months ago

In the current implementation, binary script produced by customJdk ignores specified java-opts.

I think the culprit is binaryTemplate used in cljHooks.nix which ignores java-opts:

https://github.com/jlesquembre/clj-nix/blob/52e174b2fc7805bc5a6b100d5ed7052e172a1bf2/pkgs/cljHooks.nix#L18-L23

Removing customJdk.enable = true fixes the issue but produces unoptimized JDK.

jlesquembre commented 11 months ago

Thanks for reporting, this PR should fix it: #93

You can test it by updating your nix flake input:

clj-nix.url = "github:jlesquembre/clj-nix/fix/customJdk-java-opts";