search

jlesquembre / clj-nix

Nix helpers for Clojure projects
https://jlesquembre.github.io/clj-nix/
Eclipse Public License 2.0
138 stars 19 forks source link

Fix mkCljLib and bring it closer to mkCljApp featureset #99

Closed thenonameguy closed 8 months ago

thenonameguy commented 9 months ago

I was trying to package https://github.com/schemamap/pg-query-clj/ and ran into issues with using mkCljLib. The real fix is: clj-builder being a derivation now, instead of the shell script directly.

jlesquembre commented 8 months ago

Thanks, I didn't take too much care of mkCljLib, since I don't use it much. I should add a test for it.

I'm almost sure that the test error has nothing to do with your changes, but with the latest changes on graalvm on nixpkgs. I'll try to fix those an get your PR merged on the upcoming days.

jlesquembre commented 8 months ago

Thanks again, I still have to add some tests to mkCljLib. It took me longer that expected to find why the tests were failing, but look like there is an issue with babashka and GraalVM 21, I'm disabling that test for now.

https://github.com/babashka/babashka/issues/1647

thenonameguy commented 8 months ago

Thanks for merging!

Is it resolved by locking nixpkgs to this commit by any chance? https://github.com/schemamap/schemamap/commit/7ed0f443d291d1d02c591223b6e77d222178f365#diff-8e477eb5cd8df4f353b17368bfaed21478ea70d11eaae7cab8e24aab42570561R4-R6

jlesquembre commented 8 months ago

@thenonameguy just tested that version, I'm getting the same error