Closed jlevesy closed 1 year ago
So a couple of things were wrong in how the termination was happening. This PR adresses the following issues.
Fatal
defer
This leads to much better failover time on graceful shutdowns
make run # then kill pods and look for the logs
What Does This PR do?
So a couple of things were wrong in how the termination was happening. This PR adresses the following issues.
Fatal
, which is a mistake because it does not honor the scheduleddefer
introducing a risk of not leaving the election. Never useFatal
kids.This leads to much better failover time on graceful shutdowns
How to Test This PR?
Good PR Checklist