search

jlevy / repren

Rename anything
Apache License 2.0
347 stars 39 forks source link

Add Travis CI configuration file. #12

Open sbrl opened 8 years ago

sbrl commented 8 years ago

This pull request is related to issue #11. I've added a .travis.yml file that can be used along with Travis CI. The build is currently broken, though.

If you need assistance setting up Travis CI, I'm happy to help.

jlevy commented 8 years ago

Belatedly, thanks for doing this! I'd love to have this working but haven't had much time to enhance it and set up Travis etc.

One issue is, that the run.sh runs the tests but you also need to diff them from the previous output to get a pass/fail reliably (see the script output). And of course we need to fix it so it passes in the first place. So there are a few details to worry about, but you're interested in taking that on and updating this branch once it works, I'd be glad to review/merge.

sbrl commented 8 years ago

Gosh, I'd completely forgotten about this!

Yeah, I'm happy to take this on and take a look. What exactly do you mean by

but you also need to diff them from the previous output to get a pass/fail reliably (see the script output)

?

Wouldn't it be enough if the test script exited with a non-zero error code?

Edit: The build does in fact appear to error correctly at the moment in it's current state.