jlewi / flaap

Federated Learning and Analytics Protocols
Apache License 2.0
0 stars 0 forks source link

Workers should only send back values when explicitly requested #22

Open jlewi opened 2 years ago

jlewi commented 2 years ago

As described in https://docs.google.com/document/d/10rvJdXRtgVOYNU2cj-M4ycGLoAxI2m3BKcRJQtE9nY8/edit#heading=h.sw48ol3t02xj

We can't assume that TFF fuses worker operations and that each create_call invocation will result in a value that should be materialized in the coordinator. The initial design and implementation (https://github.com/jlewi/flaap/commit/c0763b97591b582b997021f57a5dbabb210d6c0c) assumed that it did.

Furthermore, the code assumed that certain operations like create_struct weren't needed and weren't implemented but per https://github.com/jlewi/flaap/issues/19 this isn't the case and its getting invoked even in a simple average.

So we need to rearchitect things to be more of a passthrough layer.