jlewi / foyle

AI For Software Operations

https://foyle.io

Apache License 2.0

81 stars 8 forks source link

Server Cleanup: Remove GRPC and GRPC Gateway #173

Closed jlewi closed 1 day ago

jlewi commented 1 month ago

We should just use the connect server. This will simplify things a lot. We'll need to migrate the vscode extension to connect to the connect server rather than the gRPC server. Since our connect server is running on the prefix "/api"; gRPC won't work. However, since we plan on using the connect protocol for GhostCells it makes sense to use the connect protocol throughout the vscode extension when connecting to Foyle.

jlewi commented 3 weeks ago

We need to wait for https://github.com/stateful/vscode-runme/pull/1559 to be merged and released. Once that happens we can

[x] Remove gRPC and gRPC gateway from the Foyle server
[x] Remove the proxy service in Stateful protos - https://github.com/stateful/runme/blob/main/pkg/api/proto/runme/ai/v1alpha1/ai.proto
[x] Remove the proxy service in Foyle https://github.com/jlewi/foyle/blob/main/app/pkg/runme/proxy.go
[x] Update documentation

Foyle changes are released in https://github.com/jlewi/foyle/releases/tag/v0.0.16

jlewi commented 2 weeks ago

RunMe Changes to use the connect protocol were merged in https://github.com/stateful/vscode-runme/pull/1559#issuecomment-2310618819

Should be in the next release which will be 3.7.3

jlewi commented 1 week ago

3.7.3 has been released https://github.com/stateful/vscode-runme/releases/tag/3.7.3

So we should be able to proceed with removing gRPC and gRPC gateway.

jlewi commented 1 week ago

225 removed the code.

stateful/runme#662 will remove the protos in the runme repository stateful/docs.runme.dev#453 is the docs changes in the RunMe repository