jlewi / foyle

Foyle is a copilot to help developers deploy and operate their applications.
https://foyle.io
Apache License 2.0
105 stars 9 forks source link

hyperlinks opened from vscode don't include the query argument #228

Open jlewi opened 2 months ago

jlewi commented 2 months ago

Here's an example of using hccli to generate links to Honeycomb Dashboards.

The link in this case is really long and includes a query argument.

https://ui.honeycomb.io/autobuilder/environments/prod/datasets/foyle?query={"breakdowns":["eventType"],"calculations":[{"op":"COUNT"}],"filters":[{"op":"=","column":"name","value":"LogEvents"}],"time_range":86400}

When you hover over it in vscode to click and open it it only includes up to the first part. So the link ends up not working.

https://github.com/user-attachments/assets/6d187c21-d59c-4f5a-a638-7cfde768bc3f

jlewi commented 2 months ago

I think its the curly braces and quotes messing up vscode. If we paste the URL encoded link

https://ui.honeycomb.io/autobuilder/environments/prod/datasets/foyle?query=%7B%22time_range%22%3A86400%2C%22granularity%22%3A0%2C%22breakdowns%22%3A%5B%22contextID%22%5D%2C%22calculations%22%3A%5B%7B%22op%22%3A%22COUNT%22%7D%5D%2C%22filters%22%3A%5B%7B%22column%22%3A%22name%22%2C%22op%22%3A%22%3D%22%2C%22value%22%3A%22Complete%22%7D%5D%2C%22filter_combination%22%3A%22AND%22%2C%22limit%22%3A100%7D

It works. So we may want to add an option to hccli to print the encoded version.

jlewi commented 2 months ago

Interesting if you have hccli open up the URL it works just fine. e.g. by adding the --open option.