Closed jlewi closed 2 months ago
Name | Link |
---|---|
Latest commit | cf005280ed2ce3286e382a60e699baa69560038f |
Latest deploy log | https://app.netlify.com/sites/foyle/deploys/66e34bf45e47c1000908ef70 |
Deploy Preview | https://deploy-preview-233--foyle.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Learning was broken because cell executions were not being properly extracted from LogEvents and added to the BlockLog.
The problem is that the logging of LogEvents happens inside an anonymous function. Therefore the function name generated by GoLang has a suffix like "func1"; therefore our code in the Analyzer was not correctly matching it and therefore log events were not being processed.
The fix is to match by using
HasPrefix
. This is still brittle.Per #232 we'd like to start to fix this brittleness by using reflection and source code analysis in unittests to ensure the correctness of matchers for LogEntries.
This PR introduces a matchers package which verifies correctness of the function name but doesn't properly catch the anonymous function which broke learning here
Update the troubleshooting guide for learning
Strip metadata from markdown