jlewi / hydros

hydros automates hydrating and committing configuration
Apache License 2.0
4 stars 0 forks source link

PR isn't merged in a repository without automerge enabled #21

Closed jlewi closed 1 year ago

jlewi commented 1 year ago

I have a private repository in a personal account (i.e. not a team) as a result presubmit checks aren't enforced. I have branch protections turned on but these aren't enforced. I can't enable auto merge though be cause the option is disabled (because its a personal repository).

{"level":"info","ts":1676645270.226723,"caller":"github/prs.go:259","msg":"Created PR","url":"https://github.com/jlewi/hydrated/pull/82"}
{"level":"info","ts":1676645270.644184,"caller":"github/merge.go:115","msg":"PR auto-merge will be enabled and the PR will be merged when ready; this will fail if auto-merge is not allowed for the branch.","prNumber":82}
{"level":"info","ts":1676645271.054692,"caller":"github/merge.go:126","msg":"Pull request was added to merge queue and will be automatically merged when all requirements are met","prNumber":82}
{"level":"info","ts":1676645271.054883,"caller":"gitops/syncer.go:558","msg":"Sync succeeded","ManifestSync.Name":"chatapp-dev-takeover","run":"b839b"}

As a result the PR isn't merged by hydros and I end up having to run hydros twice to merge the PR.

Is this fixed if we disable branch protections on the branch?