warning about @abstract tag

myphysicslab commented 8 years ago

Getting several warnings about @abstract tag like this:

/Users/erikn/Documents/Programming/jssimlab/src/lab/engine2D/AbstractEdge.js:57: WARNING - 
Misplaced @abstract annotation. function with a non-empty body cannot be abstract
myphysicslab.lab.engine2D.AbstractEdge = function(body, vertex1, vertex2) {
^

The code there is:

/**
* @param {!myphysicslab.lab.engine2D.Polygon} body the Polygon this Edge belongs to
* @param {!myphysicslab.lab.engine2D.Vertex} vertex1 the previous vertex, in body
  coords; matches the next (second) vertex of the previous edge
* @param {!myphysicslab.lab.engine2D.Vertex} vertex2 the next vertex, in body coords
* @constructor
* @abstract
* @struct
* @implements {myphysicslab.lab.engine2D.Edge}
*/
myphysicslab.lab.engine2D.AbstractEdge = function(body, vertex1, vertex2) {

The latest version of closure compiler has fixed this problem.

jleyba commented 8 years ago

I couldn't trigger warnings with @abstract after updating, let me know if you still have problems.

myphysicslab commented 8 years ago

Confirmed this is fixed in latest version.

jleyba / js-dossier

warning about @abstract tag #80