External function parameters: invalid OPTIONAL value specified

[christina-roperto]

Plugin failed unit tests:

There was 1 error:

1) core_externallib_testcase::test_all_external_info with data set "block_configurable_reports_get_report_data" (stdClass Object (...)) Unexpected debugging() call detected. Debugging: External function parameters: invalid OPTIONAL value specified.

• line 729 of /lib/externallib.php: call to debugging()
• line 59 of /blocks/configurable_reports/classes/external.php: call to external_function_parameters->__construct()
• line ? of unknownfile: call to block_configurable_reports\external::get_report_data_parameters()
• line 122 of /lib/externallib.php: call to call_user_func()
• line 440 of /lib/tests/externallib_test.php: call to external_api::external_function_info()
• line 1154 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to core_externallib_testcase->test_all_external_info()
• line 842 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to PHPUnit\Framework\TestCase->runTest()
• line 80 of /lib/phpunit/classes/advanced_testcase.php: call to PHPUnit\Framework\TestCase->runBare()
• line 693 of /vendor/phpunit/phpunit/src/Framework/TestResult.php: call to advanced_testcase->runBare()
• line 796 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to PHPUnit\Framework\TestResult->run()
• line 746 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestCase->run()
• line 746 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestSuite->run()
• line 746 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestSuite->run()
• line 746 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestSuite->run()
• line 652 of /vendor/phpunit/phpunit/src/TextUI/TestRunner.php: call to PHPUnit\Framework\TestSuite->run()
• line 206 of /vendor/phpunit/phpunit/src/TextUI/Command.php: call to PHPUnit\TextUI\TestRunner->doRun()
• line 162 of /vendor/phpunit/phpunit/src/TextUI/Command.php: call to PHPUnit\TextUI\Command->run()
• line 61 of /vendor/phpunit/phpunit/phpunit: call to PHPUnit\TextUI\Command::main()

/var/www/site/lib/phpunit/classes/advanced_testcase.php:88

To re-run: vendor/bin/phpunit "core_externallib_testcase" lib/tests/externallib_test.php

[noisyjerm]

This error may prevent an admin being able to configure a webservice /admin/webservice/service_functions.php

As per pull request 195, Replace VALUE_OPTIONAL with VALUE_DEFAULT on line 59 in /classes/external.php 'courseid' => new external_value(PARAM_INT, 'The course id', VALUE_DEFAULT)

See:https://moodledev.io/docs/apis/subsystems/external/writing-a-service#required-optional-or-default-value