Moodle 4.1 - PHP 8.1 | Work

gemguardian commented 11 months ago

@jleyva We just want to inform you that we will be working on a M4.1 / PHP 8.1 release on the Configurable Reports block. This work will be done by Luuk Verhoeven.

The forcus will be:

Test the plugin for 4.1 with PHP 8.1 and solve any issues they encounter
Solve security risks that have been detected
Add codecheck CI Validation, though because of some legacy pieces it does mean we have to skips some test.

What won't be done is:

Solve any issues that are mentioned on Github that have nothing to do with 4.1
Change any of the current functionalities
Remove features
Rewrite the full code so it's uptodate with Moodle coding styles
Add new librarys
Removing the jQuery code since it still works in 4.1, but please do realize this will have to be rewritten in the future.
Maintaining the further code.

We expect to be able to test the new version around January 12th 2023, when we feel comfortable enough we will create a pull request and hopefull you are willing to check (if necessary) and release this new branche/request to Moodle.org/plugins

In case you have any questions or feel like certain Issues mentioned in this tracker can be part of the "Focus will be" section, It would be great if you can add it this issue.

Greetings Gemma Lesterhuis - Lesterhuis Training & Consultancy

jleyva commented 11 months ago

Hi Gemma,

that's great new, I will review the changes once submitted

fabitas commented 10 months ago

Wow, this is great. Question, because this is not clear from what won't be done "Maintaining the further code.". Will it be compatible with 4.3 too? BTW, we are using it now in 4.1. Thanks!

gemguardian commented 10 months ago

@fabitas what we mean is that we won't be actively maintaining the code or adopting the plugin. So to answer your questions: if it works with Moodle 4.3 need to be tested by the users and issues should be reported in this github.

We are right now testing 4.1 version

gemguardian commented 9 months ago

@jleyva we have finished the work for Moodle 4.1 , php 8.1 version. We are currently testing the plugin with a small community group. We are expecting to hand over the code to you at the end of February so you can do a follow up check and release it to Moodle.org , would that work for you?

gemguardian commented 8 months ago

@jleyva I just send a pull request. Even though we tested it, I think a code review would be a good idea before you merge it and release it to the community

if there are any questions please let me know.

jleyva commented 8 months ago

Thanks, I'm reviewing this but it is a huge patch! So it will take some time

luisdev commented 5 months ago

@jleyva I just send a pull request. Even though we tested it, I think a code review would be a good idea before you merge it and release it to the community

if there are any questions please let me know.

Are your changes incorporated in the new 4.1.0 release (https://github.com/jleyva/moodle-block_configurablereports/releases/tag/4.1.0)?

jleyva / moodle-block_configurablereports

Moodle 4.1 - PHP 8.1 | Work #241