jleyva / moodle-block_configurablereports

This block is a Moodle custom reports builder. You can create custom reports without SQL knowledge. It's a tool suitable for admins or teachers.
http://moodle.org/plugins/view.php?plugin=block_configurable_reports
68 stars 160 forks source link

[4.1.0] PHP 8.0 compatibility: reports/timeline/report.class.php uses gmmktime() without "hour" parameter #257

Closed danowar2k closed 1 week ago

danowar2k commented 1 week ago

A PHPCompatibility check for PHP 8.0 resulted in this here:

FILE: reports/timeline/report.class.php
--
-------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------
43 \| ERROR \| The "hour" parameter for function gmmktime() is missing. Passing this parameter is no longer
\|       \| optional. The optional nature of the parameter is removed since PHP 8.0
44 \| ERROR \| The "hour" parameter for function gmmktime() is missing. Passing this parameter is no longer
\|       \| optional. The optional nature of the parameter is removed since PHP 8.0
-------------------------------------------------------------------------------------------------------------------

PHPCompatibility 9.3.5 doesn't report this, but https://github.com/PHPCompatibility/PHPCompatibility/commit/3f79f96be9289a49eb85a4db3e8f5b7d55ba06d2 does.

danowar2k commented 1 week ago

Sorry, 4.5.0 already fixed this. Looked at the changelog and didn't see this.