jlfwong / flask_debugtoolbar_lineprofilerpanel

Line Profiler Panel for Flask Debug Toolbar
67 stars 12 forks source link

install_requires= 'line-profiler>=1.0b3' vs name = 'line_profiler' ? #5

Open matkor opened 10 years ago

matkor commented 10 years ago

Im not expert in pythoneggs stuff but I am facing problem not satisfied requirements for flask_debugtoolbar_lineprofilerpanel:

In https://github.com/rkern/line_profiler/blob/master/setup.py there is: install_requires=[ 'line-profiler>=1.0b3'

while in https://github.com/rkern/line_profiler/blob/master/setup.py there is: setup( name = 'line_profiler',

Should not install_requires be 'line_profiler>=1.0" not "line-profiler" ?

jlfwong commented 10 years ago

Does changing it to "line-profiler" fix the problem for you?

matkor commented 10 years ago

"Does changing it to "line-profiler" fix the problem for you?" No. We had to change to "line_profiler" (with underscore) like: sed -i 's/line-profiler>=1.0b3/line_profiler>=1.0/g' setup.py to exactly match line_profiler name in setup.py.

jlfwong commented 10 years ago

If you'd like to submit a pull request to make the fix, I can test it out locally and merge if it works