search

jlfwong / speedscope

🔬 A fast, interactive web-based viewer for performance profiles.
https://www.speedscope.app
MIT License
5.59k stars 247 forks source link

Rewrite property based tests using `fast-check` instead of `jsverify` #354

Open dubzzz opened 3 years ago

dubzzz commented 3 years ago

👋 Hello,

This issue is mostly opened as a suggestion.

This project relies on jsverify, a library that is not maintained anymore. The suggestion is to migrate the tests written with jsverify to fast-check.

Context jsverify's owner stopped the maintenance of the library more than a year ago. In addition, the last real commit to jsverify was on the 6th of September 2019.

Benefits of fast-check over jsverify

  1. You don't need to define unmapping fuctions on your calls to map (smap in jsverify).
  2. The arbitraries are able to find more bugs. See attached PR
  3. There is a built-in way to handle commands.
  4. Maintained.

I might have opened the PR a bit early but here is the PR: https://github.com/jlfwong/speedscope/pull/353