fix: shouldn't merge (program) call frame

jlfwong / speedscope

🔬 A fast, interactive web-based viewer for performance profiles.

https://www.speedscope.app

MIT License

5.47k stars 238 forks source link

fix: shouldn't merge (program) call frame #383

Open hyj1991 opened 2 years ago

hyj1991 commented 2 years ago

Hi, thanks for this great work!

I am able to use speedscope to analyze .cpuprofile, but sometimes it behaves differently from devtools:

CPU-20200515T093903.cpuprofile.zip

CPU-20200515T093903.cpuprofile in speedscope:

And in devtools the flamegraph is like:

https://github.com/jlfwong/speedscope/blob/main/src/import/chrome.ts#L205-L207

Maybe we shouldn't to merge the (program) frame to keep the same behavior with chrome devtools.

marvinhagemeister commented 10 months ago

This is something I'm running into frequently myself. Tried out the changes in the PR locally and they address the issue. With this PR the Chrome profiles look correct again.