Closed dalehamel closed 1 year ago
@jlfwong when you have the time to review
Status is that this seems to work, it fixes the previous issue we had with the test fixtures, but now there is an import error that fails tests.
Okay, thanks! I'll take it from here -- I'll fix this on another branch. Thanks for the followthrough
This is now live on https://speedscope.app and published to npm as part of v1.15.2. Thanks for your contribution!
thanks so much for the assistance @jlfwong i really appreciate it! we can get off of our fork now i think ❤️
The previous behavior was to use the StartLine of a function as the line number to show in speedscope. However, the Line object has more precise line information, and we should only fallback to StartLine if we don't have this more detailed information.
Looking at the documentation for the pprof proto, this is more how it intends to interpret line information:
Here is a sample profile that had line-level info on the Line object of the profile:
Before:
After:
NB i have never written anything in typscript before, but I tried to follow CONTRIBUTING.md, and run the necessary linter and tests. Note also that the linter changed other files which I didn't modify, so I didn't commit those changes.