Fix pprof defaultSampleType

vasi-stripe commented 1 year ago

Fixes #415

Interprets pprof's defaultSampleType as an index into the string table as documented in the proto, not as an index into the sample types repeated-field. This allows parsing to succeed when the string-table index is not a valid sampleTypes index, which is common on allocation profiles.
Update the pprof snapshot. This is necessarily because we were previously interpreting an empty defaultSampleType as truthy-but-zero when long.js is present, ie: the first sample-type. But Speedscope-in-the-browser doesn't seem to include long.js, so our tests were disagreeing with in-browser behavior. With this PR, that should be fixed.

coveralls commented 1 year ago

coverage: 42.119% (+0.09%) from 42.032% when pulling 9fe218085db2ca8704ae9481b2522b0d9c3bc8b9 on vasi-stripe:vasi-pprof-default into 0414c2f617742e7fb0cf31a66ac0f77c2f5c0540 on jlfwong:main.

jlfwong commented 1 year ago

Thank you!

jlfwong commented 1 year ago

This is now live on https://speedscope.app and published to npm as part of v1.15.2. Thanks for your contribution!

jlfwong / speedscope

Fix pprof defaultSampleType #424