Added support for Papyrus profiles (#427)

jlfwong / speedscope

🔬 A fast, interactive web-based viewer for performance profiles.

https://www.speedscope.app

MIT License

5.58k stars 247 forks source link

Added support for Papyrus profiles (#427) #428

Closed xieve closed 1 year ago

xieve commented 1 year ago

Here's what I have so far. There are still a couple of issues:

I couldn't get the tests to run (sh: 1: ./scripts/test-setup.sh: not found)
I've specified Profile.totalWeight but they still always start at 0
I'm not sure why Profile.stack and Profile.frames are protected, this way I have to re-implement those

xieve commented 1 year ago

Everything works now. As I said, implementation could be more ideal if I could access Profile.stack and Profile.frames, but apart from that, I'd say this is mergeable.

xieve commented 1 year ago

I've noticed one more thing: In the time order view, you can't see the things that take under 1ms, because they count as 0ms, which makes them completely invisible. Calling those functions still takes time, though, as the calls sometimes can't execute instantly and are thus put on the queue instead. I will try to implement queues as frames that contain the function calls.

xieve commented 1 year ago

Implemented all suggested changes :)

xieve commented 1 year ago

I had to change more than I anticipated, everything seems to be working as intended now.

jlfwong commented 1 year ago

Hey @xieve -- just opened a test run, and it looks like CI is failing at the moment. You can see the issue here: https://github.com/jlfwong/speedscope/actions/runs/5317035811/jobs/9678064431?pr=428

It seems like the snapshots don't match -- can you take a look, update the snapshots, and make sure the changes are as expected?

xieve commented 1 year ago

Damn, I forgot to commit the updated snapshots.