search

jlfwong / speedscope

🔬 A fast, interactive web-based viewer for performance profiles.
https://www.speedscope.app
MIT License
5.45k stars 237 forks source link

Improve profile builder performance #437

Closed Goose97 closed 1 year ago

Goose97 commented 1 year ago

Follow up on this PR #435.

Currently, it took roughly 22 seconds to load my 1.3GB file. After inspecting the profiler, there's a large chunk of time spending in Frame.getOrInsert. I figure we can reduce the number of invocations by half. It reduces the load time to roughly 18 seconds.I also tested with a smaller file (~350MB), and it show similar gains, about 15-20%

I know this is not a proper way to perform benchmarking, and also I'm clueless about the impact on other file formats/sizes. So I'll leave the judgement to you

coveralls commented 1 year ago

Coverage Status

coverage: 42.952%. remained the same when pulling da4c0b2b1e375ce7dceb526425cc3d9349288244 on Goose97:improve-profile-builder-performance into 984bf1296adefbe5f0a40c4e9f0f57e732795aab on jlfwong:main.

jlfwong commented 1 year ago

Wonderful! Nice tactical performance fix