Closed zacharyfmarion closed 8 months ago
@jlfwong one more for you before we start thinking about communicating this out 😅
Looks good! If you update the PR name to give this a more descriptive name for the commit log, I'll merge
@jfwong updated, I always miss something 😃
@zacharyfmarion you also fix things so fast it doesn't matter much 😄
Published as v1.19.0 and deployed to https://www.speedscope.app/
Because all args are serialized in the key for hermes profiles, frames were not properly getting grouped since the "parent" property was different. This PR ensures that the frame key is properly constructed from the function name, file name, line + column number.