search

jlgrock / ClosureJavascriptFramework

A group of plug-ins that can be used in conjunction with maven to execute the Google Closure Compiler on JavaScript code. This Framework allows for scaling and modularity.
MIT License
16 stars 7 forks source link

Update closure library in jsdependency-maven-plugin #20

Closed lukas-vlcek closed 11 years ago

lukas-vlcek commented 11 years ago

It seems that the closure-library.zip resource contains buggy version of Closure library sources.

I am hitting this issue when using SIMPLE_OPTIMIZATIONS: https://groups.google.com/forum/?fromgroups=#!topic/closure-library-discuss/s4PxsXfKz0A this seems to be already fixed since http://code.google.com/p/closure-library/source/detail?r=2115

It seems to be confusing because if I for example use compiler of version r2180

<plugin>
    <groupId>com.github.jlgrock.javascript-framework</groupId>
    <artifactId>closure-compiler-maven-plugin</artifactId>
    <version>1.13.2</version>
    <configuration>
        <compileLevel>SIMPLE_OPTIMIZATIONS</compileLevel>
    </configuration>
    <dependency>
            <groupId>com.google.javascript</groupId>
            <artifactId>closure-compiler</artifactId>
            <version>r2180</version>
    </dependency>
</plugin>

then the Closure library that is used is older than this.