search

jlgrock / ClosureJavascriptFramework

A group of plug-ins that can be used in conjunction with maven to execute the Google Closure Compiler on JavaScript code. This Framework allows for scaling and modularity.
MIT License
16 stars 7 forks source link

Fix for windows #23

Closed pgilmore closed 11 years ago

pgilmore commented 11 years ago

This should solve the windows issue :)

jlgrock commented 11 years ago

Definitely going to need windows support as our build server (don't even ask why) is on a windows box. :)

Anyways, I'm needed to make a bunch of tweaks as the code you added assumes that you are always installing to the /javascript folder. This is the default, but it was customizable.

So, to fix this, I reworked the code you provided to be relative to the output file. Downside is that the way the placement of javascript files was with the war, you could move the debug and compiled code independently. This is obviously no longer the case. So, everything is now going into one directory called "generated" (which is customizable, but will keep debug and compiled code together now).

Give it a shot and make sure it works for you still (after you make the adjustments to your script tags). I'm going to be testing it over the next few days with our production libraries and make sure that it works out on those as well, and I'll try and kick out a formal release early next week.

Thanks again for the help!