search

jlgrock / ClosureJavascriptFramework

A group of plug-ins that can be used in conjunction with maven to execute the Google Closure Compiler on JavaScript code. This Framework allows for scaling and modularity.
MIT License
16 stars 7 forks source link

A new compiler version r2388 has been released. Shall we upgrade? #26

Closed lukas-vlcek closed 11 years ago

lukas-vlcek commented 11 years ago

As long as #11 is not solved, can we upgrade to the new version of Closure Compiler and Library?

See http://code.google.com/p/closure-compiler/wiki/Maven

It seems some bugs were fixed: http://code.google.com/p/closure-compiler/wiki/Releases

lukas-vlcek commented 11 years ago

By upgrade I mean the same that was done in #21.

jlgrock commented 11 years ago

OK, release with 2388 is done. This one was a little tougher as they've created some interesting differences in the compiler that required me to make some updates.

This release comes with some other new stuff as well. I have started some release notes now to keep anyone interested up to date. Also, I've subscribed to the RSS to get the updates quicker, but feel free to send me another one of these if you see it before me. :)

lukas-vlcek commented 11 years ago

Good to see the RELEASE_NOTES. Just an idea, would you mind using markdown format for it? It would allow better viewing on GitHub.

lukas-vlcek commented 11 years ago

BTW, you mentioned that they (Google) did some more changes, added new stuff. Does it mean one has to pay attention to something special when upgrading to recent version? (from r2180 to r2388)

According to http://code.google.com/p/closure-compiler/wiki/Releases I would assume the upgrade should be quite painless.

jlgrock commented 11 years ago

they've been very vague. The two main things that you need to watch out for are the bullet points for "type checking fixes" and "new warning: misplaced type annotation", basically, it's more strict about casting, especially when used in closures. If you are using WARNING or STRICT, you'll find out immediately, because it will break the builds. It's useful though, cause apparently we were casting incorrectly all over the place, and it helps catch those.

As for the release notes, it is in markdown, but I forgot to add the ".md" extension. I'll add it soon.