Allow browser version configuration for HtmlUnitDriver. Closes #45

jlgrock / ClosureJavascriptFramework

A group of plug-ins that can be used in conjunction with maven to execute the Google Closure Compiler on JavaScript code. This Framework allows for scaling and modularity.

MIT License

16 stars 7 forks source link

Allow browser version configuration for HtmlUnitDriver. Closes #45 #46

Closed lukas-vlcek closed 10 years ago

lukas-vlcek commented 10 years ago

@jlgrock Please feel free to review and let me know if there is anything missing. If this is getting merged then we need to update release notes and then we can release v1.18.1 and deploy to public maven repo. I am looking forward to using this new version asap :smile:

lukas-vlcek commented 10 years ago

Cool, thanks!

jlgrock commented 10 years ago

Hey, no worries. The code looked good to me. Sonatype has changed a couple of things when releasing to their servers, so I suggest if you need it quick, you may want to add them as a proxy to your local nexus repository or a mirror in .m2/settings.xml. It should be published though.

lukas-vlcek commented 10 years ago

As of now it is already in maven central. Thanks.