search

jlgrock / ClosureJavascriptFramework

A group of plug-ins that can be used in conjunction with maven to execute the Google Closure Compiler on JavaScript code. This Framework allows for scaling and modularity.
MIT License
16 stars 7 forks source link

Skip tests - how to? #50

Closed lukas-vlcek closed 10 years ago

lukas-vlcek commented 10 years ago

I do not think it is possible to easily skip JavaScript tests now. What exactly needs to be done (implemented) in order to enable skipping tests via -DskipTests option?

jlgrock commented 10 years ago

Something in the Maven framework changed and it broke skipTests. I have updated the code using the new Plugin Tools Java5 Annotations. Check it out and let me know if it works for you. I also updated the wiki (https://github.com/jlgrock/ClosureJavascriptFramework/wiki/Testing).

lukas-vlcek commented 10 years ago

Excellent!

I am giving a try to 1.18.2-SNAPSHOT but I am getting the following error:

[ERROR] Failed to execute goal com.github.jlgrock.javascript-framework:jsar-maven-plugin:1.18.2-SNAPSHOT:jsar (default-jsar) on project core: The parameters 'outputDirectory' for goal com.github.jlgrock.javascript-framework:jsar-maven-plugin:1.18.2-SNAPSHOT:jsar are missing or invalid -> [Help 1]

To replicate this clone https://github.com/searchisko/search.jboss.org-ui, locate the pom.xml in root and upgrade to <jsframework.version>1.18.2-SNAPSHOT</jsframework.version> and execute mvn clean package.

jlgrock commented 10 years ago

Yup, I missed the default on that parameter. I've corrected it. I think it works on your project. Fun project, btw. I may have to look at that a bit more later.

lukas-vlcek commented 10 years ago

Yes, it seems to work great now. Thanks a lot. I will be testing it more tomorrow and report back if I find any issues. Do you think we could have this released before end of this week? For example as 1.18.2?

jlgrock commented 10 years ago

No problem. I just released it (though it can take a little while to propagate from the Sonatype nexus to maven central). If you run into any other issues, just drop a bug in.

lukas-vlcek commented 10 years ago

@jlgrock Still can not find 1.18.2 release either in https://search.maven.org/#browse%7C236026165 or http://mvnrepository.com/artifact/com.github.jlgrock.javascript-framework/jsar-maven-plugin Do you have any idea why?

jlgrock commented 10 years ago

yeah. i forgot to manually push the "release" button on the sonatype nexus. annoying. try it again in a couple of hours (or look for it in sonatype's repo)