jlgrock / ClosureJavascriptFramework

A group of plug-ins that can be used in conjunction with maven to execute the Google Closure Compiler on JavaScript code. This Framework allows for scaling and modularity.
MIT License
16 stars 7 forks source link

Closure's deps.js file is not included by default #55

Open mgobeil opened 9 years ago

mgobeil commented 9 years ago

When I ran with ADVANCED_OPTIMIZATIONS, I got errors like: closure/closure/goog/events/events.js:896: ERROR - Bad type annotation. Unknown type goog.debug.ErrorHandler

Suggesting this problem: https://code.google.com/p/closure-library/wiki/FrequentlyAskedQuestions#When_I_compile_with_type-checking_on,_I_get_warnings_about_"

Solved by including closure-library/closure/goog/deps.js. I noticed in the code that closure-library/closure/goog/base.js is included automatically in com.github.jlgrock.javascriptframework.closurecompiler.JsClosureCompileMojo.execute() using getBaseLocation(closureLibraryLocation), and after adding a similar inclusion for deps.js, the problem went away.