search

jlhonora / lsusb

lsusb command for Mac OS X
MIT License
368 stars 49 forks source link

missing manufacturer from the -t option #8

Closed dardo82 closed 9 years ago

dardo82 commented 9 years ago

Why there is no manufacturer's name in the output of the "tree" option?

johnfreed commented 9 years ago

lsusb is a clone of the Linux function. If you want an enhancement there are two routes: 1) ask the Linux maintainers to add it 2) write a new switch with the enhancement (see the parens switch as an example)

Your chance of success with #1 is probably low. On Sep 12, 2015 6:59 AM, "Michele Venturi" notifications@github.com wrote:

Why there is no manufacturer in the output of the tree option?

— Reply to this email directly or view it on GitHub https://github.com/jlhonora/lsusb/issues/8.

dardo82 commented 9 years ago

Have you seen the related commit from my fork? Could you please merge it? (https://github.com/dardo82/lsusb/commit/23a3055ae1d2424379630e93d39d564f0a7efdcd)

johnfreed commented 9 years ago

Well just glancing at it I believe it changes the function of the -t switch. Perhaps you could rewrite using for example a -T switch On Sep 12, 2015 12:12 PM, "Michele Venturi" notifications@github.com wrote:

Have you seen the related commit from my fork? Could you please merge it? (dardo82@23a3055 https://github.com/dardo82/lsusb/commit/23a3055ae1d2424379630e93d39d564f0a7efdcd )

— Reply to this email directly or view it on GitHub https://github.com/jlhonora/lsusb/issues/8#issuecomment-139749567.

jlhonora commented 9 years ago

As John says, this repo tries to emulate lsusb's functionality as close as what the Linux version does. If you use an unused flag (such as -T) I'd be glad to merge it, but:

  1. If another function using -T is added in Linux then we'll probably change this one.
  2. Please add documentation on what is its expected output.

Thanks in advance.

dardo82 commented 9 years ago

So there is no manufacturer in the tree option's output in the linux version? I'm using OS X at the moment,so i don't know it for sure,as i don't know why they should add a new option in the future. Anyway i think i'll try to see if can add the option separately and update the man page too,ok? 8-)

jlhonora commented 9 years ago

Yes, no manufacturer in -t. As for the separate switch, that'd be great.

dardo82 commented 9 years ago

I have updated the pull request https://github.com/jlhonora/lsusb/pull/9. Can you please review it?