search

jlhood / github-codebuild-logs

Serverless App that publishes CodeBuild build logs to a publicly accessible location
MIT License
88 stars 22 forks source link

Change `DeletePreviousComment` to an int #35

Closed msaroufim closed 1 year ago

msaroufim commented 2 years ago

Context

Hi I'm one of the maintainers of torchserve at PyTorch which we comaintain with AWS and we use codebuild and your bot to be able to share with community members issues with their PRs. We can't share the codebuild links directly since they're internal to AWS.

When we run our CI we need to pass on both linux-cpu, linux-gpu and windows so there's a total 3 of comments that need to show and not just 1

https://github.com/pytorch/serve/pulls

Problem

However often our CI is flaky or it takes a few commits for people to get their PR right so we end up with with dozens of comments from a bot which drown out the useful comments like reviews. And we can't set DeletePreviousComment because we need 3 comments to show at a time at a minimum from each of the distributions

Proposed solution

So if we could instead the number of previous comments to be something like 3 or 6 it makes the discussions on github PRs much more readable.

Screen Shot 2022-02-18 at 2 18 25 PM
PatMyron commented 1 year ago

Editing the same comment repeatedly seems better than spamming threads or losing reports: https://github.com/jlhood/github-codebuild-logs/issues/25#issuecomment-1537283981

msaroufim commented 1 year ago

Closing for now since I no longer need this