search

jlib-framework / jlib-awslambda-logback

jlib AWS Lambda SLF4J/Logback Appender
Apache License 2.0
22 stars 0 forks source link

Can I use slf4j 1.7.30? #3

Open lestephane opened 4 years ago

lestephane commented 4 years ago

I'm wondering if your use of a 1.8 beta version of slf4j is deliberate...

igorakkerman commented 4 years ago

Hi @lestephane,

The short answer is: I believe you can use SLF4J 1.7 but it hasn't been tested.

When I initially developed the library, it seemed like SLF4J 1.8 would be officially released soon, which is why I decided to test with the latest available version and to also in the documentation suggest to use 1.8. However, this library only has a runtime dependency on SLF4J and afaik no 1.8 specific API is being used. But this has not been tested.

In case you want to give it a try, I'd be thrilled to hear from your experience.

lestephane commented 4 years ago

I'm going to test this, but I can't get it to work even with 1.8 as it stands. I'll file a separate issue for that when I have time.

igorakkerman commented 4 years ago

Thank you! I will try to assist you with both issues to the best of my abilities.

masooh commented 3 years ago

Unfortunately it does not work with slf4j 1.7.30. 

 SLF4J: Defaulting to no-operation (NOP) logger implementation                                                                                                                                                                                                               
 SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

This is due to the missing StaticLoggerBinder which is present in logback-classic 1.2.3, but absent in 1.3.0-alpha4.

SLF4J 1.8 and Loback 1.3 seems to have breaking changes according to https://stackoverflow.com/questions/55745651/logback-upgrade-from-1-1-11-to-1-3-0-alpha4-in-spring-boot-1-5-8-application