search

jliljebl / flowblade

Video Editor for Linux
GNU General Public License v3.0
2.68k stars 181 forks source link

can't delete range log items #1122

Open wolfgangr opened 1 year ago

wolfgangr commented 1 year ago

Please include the following information. 1) Flowblade version (Help->About): git checkout master as of 2023-10-04 2) MLT version (Help->Runtime Environment): 7.18.0 3) Your distribution (Ubuntu, Debian, Mint etc.): deb 10 4) If possible, try to provide step-by-step instructions on how to reproduce the issue. From developer point of view this is the easieast way to understand what is happening.:

on the console I started flowblade, I can read:

Traceback (most recent call last):
  File "/home/wrosner/test/flowblade/flowblade-2.11/flowblade-trunk/Flowblade/medialog.py", line 725, in <lambda>
    delete_button.connect("clicked", lambda w:delete_selected())
  File "/home/wrosner/test/flowblade/flowblade-2.11/flowblade-trunk/Flowblade/medialog.py", line 218, in delete_selected
    PROJECT().remove_from_group(i, delete_events)
  File "/home/wrosner/test/flowblade/flowblade-2.11/flowblade-trunk/Flowblade/projectdata.py", line 320, in remove_from_group
    for i in items:
ValueError: list.remove(x): x not in list

possible clue: my mouse is jittering sometimes. So accidentially, this way I produced two log entries with the same File Name and Mark in/out values and creation time. May this cause skd of duplicate key error? I can edit comment and change star independently, however. The problem of "indeletability" is not confined to the duplicate entries.

wolfgangr commented 1 year ago

update:

I can move items to "Group" I can delete item from Group or even whole Group. However, in "All items", they are still there.

on flowblade console, I repeatedly read:

(flowblade:29772): Gtk-WARNING **: 23:04:16.166: Duplicate child name in GtkStack: Move Selected Items To Group

(flowblade:29772): Gtk-WARNING **: 23:04:16.223: Duplicate child name in GtkStack: Sort by
jliljebl commented 1 year ago

Thanks, will look at this.

jliljebl commented 1 year ago

Could not reproduce the "failing to delete" bug, but I did get: 

(flowblade:6706): Gtk-WARNING **: 10:30:16.356: Duplicate child name in GtkStack: Sort by

(flowblade:6706): Gtk-WARNING **: 10:30:47.004: Duplicate child name in GtkStack: Move Selected Items To Group

(flowblade:6706): Gtk-WARNING **: 10:30:47.005: Duplicate child name in GtkStack: Move Selected Items To Group

(flowblade:6706): Gtk-WARNING **: 10:30:47.008: Duplicate child name in GtkStack: Sort by

(flowblade:6706): Gtk-WARNING **: 10:30:47.009: Duplicate child name in GtkStack: Sort by

Something is wrong here.

jliljebl commented 1 year ago

On 2.120.0.4 Flatpak everything works fine, so this is a regression because of moving to use Gtk.Popover menus as step towards Gtk4 transition.

jliljebl commented 1 year ago

Will keep this for additional info but I'll handle the (flowblade:6706): *Gtk-WARNING *: 10:30:47.009: Duplicate child name in GtkStack: Sort by separately.